Skip to content

Analytics Hub: Release Custom Date Ranges #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2022
Merged

Analytics Hub: Release Custom Date Ranges #8414

merged 3 commits into from
Dec 15, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Dec 14, 2022

Why

This PR does 3 things:

  • Update the calendar padding following the design review recomendation
  • Removes the custom cases outside the feature flag control
  • Updates the readme

Screenshot (For the calendar padding)

calendar-padding

Notes

Please don't before #8411 && #8413

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Dec 14, 2022
@Ecarrion Ecarrion added this to the 11.7 milestone Dec 14, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 14, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@Ecarrion Ecarrion force-pushed the issue/release-custom-range branch from 3ffca80 to 9418ad5 Compare December 14, 2022 17:34
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 14, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8414-9418ad5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr self-assigned this Dec 15, 2022
rachelmcr
rachelmcr approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Just a nit about the calendar padding change: I'm seeing a new console message [UICalendarView] UICalendarView's height is smaller than it can render its content in; defaulting to the minimum height. only in this branch. It looks like this is a quirk of SwiftUI's DatePicker and not an issue in the resulting layout, so I'm just mentioning it in case you're aware of a way to address that.

@Ecarrion
Copy link
Contributor Author

Ecarrion commented Dec 15, 2022

Good catch @rachelmcr! I didn't notice the warning before but it is happening in the trunk too.
The message seems quite clear tho: The calendars can't be shrunk more in order to fit both in the visible area, so it is using a minimum system-defined height. 🤷

@Ecarrion Ecarrion merged commit 51e78c2 into trunk Dec 15, 2022
@Ecarrion Ecarrion deleted the issue/release-custom-range branch December 15, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

4 participants

@Ecarrion @wpmobilebot @rachelmcr